Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding ImageExtension.resize #2418

Merged
merged 8 commits into from
Mar 31, 2023
Merged

feat: Adding ImageExtension.resize #2418

merged 8 commits into from
Mar 31, 2023

Conversation

erickzanardo
Copy link
Member

Description

Adds a helper method to ImageExtension to make it easier to resize an image.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@erickzanardo erickzanardo requested review from st-pasha and a team March 18, 2023 20:17
spydon
spydon approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, one minor comment

packages/flame/lib/src/extensions/image.dart Outdated Show resolved Hide resolved
luanpotter
luanpotter approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erickzanardo erickzanardo enabled auto-merge (squash) March 31, 2023 11:29
@spydon spydon disabled auto-merge March 31, 2023 11:33
@spydon spydon enabled auto-merge (squash) March 31, 2023 11:33
@spydon spydon merged commit a3f1601 into main Mar 31, 2023
@spydon spydon deleted the erick.image-resize-extension branch March 31, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@luanpotter luanpotter luanpotter approved these changes

@renancaraujo renancaraujo renancaraujo approved these changes

@st-pasha st-pasha Awaiting requested review from st-pasha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erickzanardo @spydon @luanpotter @renancaraujo