Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add interactive example for Anchor #2523

Merged
merged 10 commits into from
May 1, 2023

Conversation

ufrshubham
Copy link
Member

Description

This PR add an interactive example to show the parent child relationship when their anchors are changed. It also elaborates the same in written docs as well.

AnchorExampleDemo.mp4

Checklist

  • I have followed the [Contributor Guide] when preparing my PR.
  • [-] I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #2510

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Maybe it could be good to clarify that the position is 0,0 for the child?

@ufrshubham
Copy link
Member Author

Looks good! Maybe it could be good to clarify that the position is 0,0 for the child?

Should I updated that in the infobox comment under the example?

@spydon
Copy link
Member

spydon commented May 1, 2023

Should I updated that in the infobox comment under the example?

Wherever you think it looks the best :)

doc/flame/components.md Outdated Show resolved Hide resolved
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
@spydon spydon merged commit a4f60a8 into main May 1, 2023
@spydon spydon deleted the devkage/anchor-interactive-example branch May 1, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive example that explain how Anchor works
2 participants