fix: Remove mustCallSuper from onComponentTypeCheck
#2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mustCallSuper is very strict requirement. This is true only for hitboxes, but unnecessary for other game components.
spydon
reviewed
May 31, 2023
spydon
changed the title
mustCallSuper from onComponentTypeCheck
|
In fact, the decision is always up to game developer. If he want to leave a chance to owerride the type check in parent component - super should be calles. Otherways it only waste system recources. |
|
Yes, the decision is up to the game developer, but we should inform them of what is happening when super is called and with an example for when they'd want to do it so that the developer can make an informed decision on whether they should call super or not. |
|
Because there are cases when the developer would want to call super right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@mustCallSuper is very strict requirement. This is true only for hitboxes and internal engine's logic, but unnecessary for other, "client-side" game components.
When overriding
onComponentTypeCheckfor component you can simple return true or false and this would not break anything.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?