Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove mustCallSuper from onComponentTypeCheck #2561

Merged
merged 3 commits into from
Jun 2, 2023
Merged

fix: Remove mustCallSuper from onComponentTypeCheck #2561

merged 3 commits into from
Jun 2, 2023

Commits on May 31, 2023

  1. fix: onComponentTypeCheck really MUST call super only for hitboxes 

    @mustCallSuper is very strict requirement. This is true only for hitboxes, but unnecessary for other game components.
    @ASGAlex
    ASGAlex committed May 31, 2023
    Configuration menu
    Copy the full SHA
    762fac3 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. doc: detailed description about super.onComponentTypeCheck usage

    @ASGAlex
    ASGAlex committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    1188b79 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @spydon
    spydon authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    5c4491e View commit details
    Browse the repository at this point in the history