Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option for a custom image and asset loader #2569

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

CodeDoctorDE
Copy link
Contributor

Description

Add images and bundle to the named parameters for the creation of a tiled map.

Checklist

  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

No

Migration instructions

-

Related Issues

Closes #2568

@CodeDoctorDE
Copy link
Contributor Author

I don't know why the ci fails

Test run was interrupted.
Error: The operation was canceled.

@spydon
Copy link
Member

spydon commented Jun 9, 2023

Sometimes the test stage gets cancelled by the CI for unknown reasons, this is what happened here.
What is strange is that the analyze step passed, because there are a few analyze issues, one line that is too long and some missing trailing commas (you can see the issues annotated in the files tab in GitHub).

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@spydon spydon merged commit dfe1825 into flame-engine:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiled asset loader
2 participants