Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Move
Forge2DGame
to useCameraComponent
#2728feat!: Move
Forge2DGame
to useCameraComponent
#2728Changes from 20 commits
e43cb21
6520253
56e5374
6e6c3cd
4d9c78a
5e76cc5
1a1cf5f
fccc65e
726a278
918638e
53dd6e2
84fe542
0b63e5a
2070a7e
b220b71
38b1944
2409bd5
2818512
c23790f
d5a74f3
0a68dc1
7a957ee
0da0eb9
112e1a6
eada637
7783ab0
248efea
475129f
4c26d64
814d980
299ad75
23cf212
e9de3cd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the rename from gameRef to game?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is from the really old Pasha PR where we are moving from the
HasGameRef
mixin toHasGameReference
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine this is because it gets re-added later and you want to call onLoad to reset the game? just curious what breaks if you just leave the camera there as is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This camera isn't used, it uses several other cameras later instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine things like this and initialPosition are to avoid conflict with a position defined on BodyComponent.
but why can't we just use that position for everything? where do components need to keep a separate track of a second position?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
position
is a read-only onBodyComponent
since it is a getter from theBody
.