-
-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add collision completed listener #2896
Merged
spydon
merged 24 commits into
flame-engine:main
from
christian-mindfulness:add_collision_completed
Dec 6, 2023
Merged
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
4b8bdd5
First attempt at creating onCollisionsCompleted
5d42eed
Bug fix which gets things working.
f4ab7b9
First attempt at adding tests
76d2970
Revert "First attempt at adding tests"
1216440
Revert "First attempt at creating onCollisionsCompleted"
e9dba44
Revert "Bug fix which gets things working."
d49d3da
Add ChangeNotifier to collision detection.
05db541
Add an override of the ChaneNotifier class and start documentation.
015f9bd
Add a description of new ChangeNotifier override.
92eb7c5
Remove changes from shape hitbox.
e6256db
Switch from ChangeNotifier to implementing Listenable.
09fec9c
Merge branch 'main' into add_collision_completed
21e8725
Update comment for Listener class
362ad63
Fix markdown lint failure
82b6745
Merge branch 'main' into add_collision_completed
christian-mindfulness 9d74231
Update packages/flame/lib/src/collisions/collision_detection.dart
christian-mindfulness 834c950
Change name of notifier, as requested in review
2b9c946
Notify class inherits from ChangeNotifier, rather than Listenable.
66879ca
Add first version of notifier test.
8e16121
Bug fix on flame test.
6b779c2
Fixes following @spydon's review.
13b3905
Fix change notifier.
2f9fc20
Update formatting in docs
a9308c9
Merge branch 'main' into add_collision_completed
spydon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the correct formatting