feat: Support for new atlas format and rotated sprites #3097
Conversation
…iginalWidth, originalHeight, degrees, rotate, index. So we set the defaults in code
Yayo-Arellano
force-pushed
the
add_support_to_rotation_and_new_file_format
branch
4 times, most recently
from
bb3f6c6
to
5f48e6d
Compare
spydon
changed the title
| flame_texturepacker: | ||
| path: ../ |
There was a problem hiding this comment.
This should not be modified, Melos keeps track of this through the pubspec_overrides.yaml file
There was a problem hiding this comment.
Got it. I removed the commit
| @@ -297,3 +296,14 @@ extension _IteratorExtension on Iterator<String> { | |||
| return null; | |||
| } | |||
| } | |||
|
|
|||
| extension _IterableExtension<T> on Iterable<T> { | |||
| T? firstWhereOrNull(bool Function(T element) test) { | |||
There was a problem hiding this comment.
This is already built-in to collection:
https://api.flutter.dev/flutter/package-collection_collection/IterableExtension/firstWhereOrNull.html
So just import collection instead, since we use that everywhere else.
There was a problem hiding this comment.
Got it. I updated the code to use the build-in collection
| ) { | ||
| _decorator = Transform2DDecorator(_transform); | ||
| if (region.rotate) { | ||
| _transform.angle = radians(90); |
There was a problem hiding this comment.
| _transform.angle = radians(90); | |
| _transform.angle = math.pi / 2; |
| _transform.angle = radians(90); | |
| _transform.angle = tau / 4; |
We should limit the use of degrees as much as possible.
There was a problem hiding this comment.
Got it. Code updated
| static final _tmpRenderSize = Vector2.zero(); | ||
|
|
||
| @override | ||
| void render( |
There was a problem hiding this comment.
Sound all this be skipped if there is no rotation set?
So that super.render is called if there is no rotation, since that should be more performant?
There was a problem hiding this comment.
This is a good idea. I updated the code
Yayo-Arellano
force-pushed
the
add_support_to_rotation_and_new_file_format
branch
from
5f48e6d
to
b731530
Compare
Yayo-Arellano
force-pushed
the
add_support_to_rotation_and_new_file_format
branch
from
b731530
to
5449f1a
Compare
Yayo-Arellano
force-pushed
the
add_support_to_rotation_and_new_file_format
branch
from
5449f1a
to
55286c2
Compare
|
@spydon Hello. I have updated/replied to the comments. Please take a look when you have some time. |
|
@spydon There is a broken test case. But the code is not related to this pull request. Can you take a look? |
It was the annoying flaky test that was acting up again, re-ran it and now the PR is merged. :) |
Description
Added support to load new atlas format and support for rotated sprites
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues