fix: Invoke setToStart on child effect controller of wrapping effect controllers
#3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
reviewed
May 24, 2024
packages/flame/lib/src/effects/controllers/mixins/has_single_child_effect_controller.dart
Show resolved
Hide resolved
spydon
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DelayedEffectControllerwas not callingsetToStarton its child, causing it to not behave as expected when used withInfiniteEffectController. This was reported by a discord member in this message.This PR introduces a
HasSingleChildEffectControllermixin which can be added to any effect controller that wraps a single child effect controller. This mixin makes sure that thesetToStart,setToEndandonMountmethods always get invoked on the child controllers.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
NA