refactor: Use a temp vector for delta calculations of FollowBehavior
#3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanpotter
reviewed
Jul 21, 2024
luanpotter
reviewed
Jul 21, 2024
| if (delta.x != 0 || delta.y != 0) { | ||
| owner.position = delta..add(owner.position); | ||
| if (_tempDelta.x != 0 || _tempDelta.y != 0) { | ||
| owner.position = _tempDelta..add(owner.position); |
There was a problem hiding this comment.
to go all the way avoiding object creation entirely, this could be owner.position.setValues(owner.position.x + delta.x, ...)
sadly we lose all the easiness of using vectorial math at all when doing things like this
There was a problem hiding this comment.
this could be owner.position.setValues(owner.position.x + delta.x, ...)
I thought the same. But unfortunately doing so causes some of the tests to fail, because the .setValues bypasses the position setter of PositionProvider. Some components do extra stuff in that setter.
There was a problem hiding this comment.
oof, seems like a footgun waiting to happen :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add a temp vector in
FollowBehaviorto avoid creating a new vector every frame for the delta calculations.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
NA