Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clarify SpriteGroupComponent.updateSprite assertion #3317

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Sep 21, 2024

Description

Now the assertion is slightly clearer for what the user has done wrong when calling the SpriteGroupComponent.updateSprite in an instance without an initialized sprites map.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

@spydon spydon merged commit d976ee8 into main Sep 22, 2024
8 checks passed
@spydon spydon deleted the chore/clarify-assertion branch September 22, 2024 13:08
luanpotter pushed a commit that referenced this pull request Oct 15, 2024
Now the assertion is slightly clearer for what the user has done wrong
when calling the `SpriteGroupComponent.updateSprite` in an instance
without an initialized `sprites` map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants