-
-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: New AlternatePattern
argument for SequenceEffect
#3322
Draft
TheMaverickProgrammer
wants to merge
9
commits into
flame-engine:main
Choose a base branch
from
TheMaverickProgrammer:feature/improved_sequence_effect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat!: New AlternatePattern
argument for SequenceEffect
#3322
TheMaverickProgrammer
wants to merge
9
commits into
flame-engine:main
from
TheMaverickProgrammer:feature/improved_sequence_effect
+176
−39
Commits on Sep 24, 2024
-
Fixed math in MoveToEffect so that negative progress did not reflect …
…the direction of the delta offset vec. Corrected progress getter overload in SequenceEffect to correctly map to the progess when _index < 0. Added onStart() in the initial conidition of ecede() so that effects like MoveEffect can recalculate their initial data. Removed unnecessary math in DurationEffectController to avoid potential negative zeros. Replaced �lternate boolean for SequenceEffect with a new type AlternatePattern which allows users to include or exlude the last effect in the sequence when the pattern reverses. Default value is now AlternatePattern.none. Updated all SequenceEffect examples and tests to reflect changes. Made the TiledGame example project more aesthetically interesting. The camera now pans to all 4 corners WRT the bounds of the loaded map and uses the new AlternatePattern feature along with all the new fixes.
Configuration menu - View commit details
-
Copy full SHA for 80166b1 - Browse repository at this point
Copy the full SHA 80166b1View commit details -
Removed unnecessary abs(). Forgot to revert recede() after local test…
…ing so that is fixed.
Configuration menu - View commit details
-
Copy full SHA for dd1fc7b - Browse repository at this point
Copy the full SHA dd1fc7bView commit details
Commits on Nov 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d107787 - Browse repository at this point
Copy the full SHA d107787View commit details -
Configuration menu - View commit details
-
Copy full SHA for faa32b9 - Browse repository at this point
Copy the full SHA faa32b9View commit details -
renamed enum to be clearer. Restored �lternate boolean. Added logic t…
…o skip start element whendoNotRepeatLast is true and the pattern is playing in reverse.
Configuration menu - View commit details
-
Copy full SHA for d05e3ee - Browse repository at this point
Copy the full SHA d05e3eeView commit details
Commits on Nov 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ed63c41 - Browse repository at this point
Copy the full SHA ed63c41View commit details -
Configuration menu - View commit details
-
Copy full SHA for ece8953 - Browse repository at this point
Copy the full SHA ece8953View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dd88a1 - Browse repository at this point
Copy the full SHA 6dd88a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ea5e9f - Browse repository at this point
Copy the full SHA 2ea5e9fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.