Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented --omit-symbols=LIST configure option. #823

Merged
merged 2 commits into from
Oct 16, 2024

Commits on Aug 1, 2024

  1. Implemented --omit-symbols=LIST configure option.

    Details:
    - Added a new option to 'configure' that allows the user to specify a
      list of symbols to omit from the library. The format of the option is
      --omit-symbols=LIST where LIST is a comma-separated list of symbol
      names (excluding any trailing underscore). This list is parsed into
      a list of #define directives that causes the relevant parts of BLIS
      to be ignored (or not). As such, the nature of this option is to only
      support omitting symbols which have been pre-identified as potential
      troublemakers when linking BLIS with other libraries such as LAPACK
      or ScaLAPACK. (This list may grow in the future as additional symbols
      are identified.)
    - Re-implemented the --enable-scalapack-compat configure option to
      utilize the underlying --omit-symbols=LIST infrastructure.
    - Implemented an --enable-lapack-compat option, which omits all of the
      known problematic symbols currently supported for omission.
    - This commit addresses Issue #816. Thanks to Timo Betcke for bringing
      it to our attention and to Devin Matthews for his advice and for
      his initial implementation of --enable-scalapack-compat (PR #813).
    - CREDITS file update.
    fgvanzee committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    3899dae View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Fixed typos; leave lsame/xerbla prototypes enabled.

    Details:
    - Leave lsame_() and xerbla_() prototypes enabled even when their
      respective symbols are omitted from the library.
    - Fixed copy-and-paste bug.
    - Fixed typos in the #define directives.
    fgvanzee committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    857d862 View commit details
    Browse the repository at this point in the history