Fix #1697 and #1726 #1782
Merged
Fix #1697 and #1726 #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2021
|
The changes look good, ill test this on my small machine later and get it merged. |
Signed-off-by: Haris Gušić <harisgusic.dev@gmail.com>
Signed-off-by: Haris Gušić <harisgusic.dev@gmail.com>
Signed-off-by: Haris Gušić <harisgusic.dev@gmail.com>
borgmanJeremy
approved these changes
Jul 31, 2021
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed ConfigWindow to inherit QWidget and moved QTabWidget to be an
attribute. setMinimumSize is no longer necessary in ConfigWindow.
Signed-off-by: Haris Gušić harisgusic.dev@gmail.com