Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce max thickness #1940

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

mgalgs
Copy link
Contributor

@mgalgs mgalgs commented Oct 4, 2021

The thickness slider is fairly small, so it's difficult to make small
adjustments. The max value of the thickness slider is currently 100, which
is actually pretty huge.

Since most common use cases involve smaller pixel values (closer to the
0-10 range, I suspect), reduce the maximum slider value to 25, allowing for
easier fine grained control of the drawing thickness.

Although fine grained control is already possible via the scroll wheel,
this change improves the overall usability of the tool, especially for new
users who many not know that thickness can be adjusted with the scroll
wheel (or for users who don't have a scroll wheel).

Screenshots

Maxed out thickness, before this change:

flameshot_max_active_thickness_before

Maxed out thickness, after this change:

flameshot_max_active_thickness_after

@borgmanJeremy
Copy link
Contributor

@mmahmoudian this looks good to me. Any concerns?

@mmahmoudian
Copy link
Member

I can see the logic and I agree with it, but maybe 25 is too small? I'm thinking that 4k people are more likely to use larger values, therefore 25 seems to be pretty narrow for them. How about 50?

The thickness slider is fairly small, so it's difficult to make small
adjustments. The max value of the thickness slider is currently 100, which
is actually pretty huge.

Since most common use cases involve smaller pixel values (closer to the
0-10 range, I suspect), reduce the maximum slider value to 25, allowing for
easier fine grained control of the drawing thickness.

Although fine grained control is already possible via the scroll wheel,
this change improves the overall usability of the tool, especially for new
users who many not know that thickness can be adjusted with the scroll
wheel (or for users who don't have a scroll wheel).
@mgalgs mgalgs force-pushed the max-thickness-reduction branch from 4af13c9 to 3be7a2b Compare October 6, 2021 20:43
@mgalgs
Copy link
Contributor Author

mgalgs commented Oct 6, 2021

I'm thinking that 4k people are more likely to use larger values, therefore 25 seems to be pretty narrow for them. How about 50?

Good point, done!

@borgmanJeremy
Copy link
Contributor

Thanks!

@borgmanJeremy borgmanJeremy merged commit c2ea8b6 into flameshot-org:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants