Explain why saving a screenshot might fail #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Michael-F-Bryan Thank you for your contribution. This will definitely prevent some issues from being reported repeatedly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My
~/Picturesfolder is located in a separate partition, and for whatever reason it was mounted in readonly mode. When I tried to save a screenshot, flameshot was just saying, "Error trying to save as /home/michael/Pictures/2021-10-27_12-56.png", without giving any real explanation for what went wrong.I ended up scratching my head for a good 5-10 minutes trying to figure out why saving was failing when the folder exists and it has all the right permission. I only figured out what the issue was when I tried to create a file and
touchgave me a more useful error message - "touch: cannot touch '/home/michael/Pictures/asdf': Read-only file system".This PR modifies the way we save screenshots to write to a
QFileand appendfile.errorString()to the error message if the save error was file-related.