Optimize various SVGs #2130

RiedleroD · 2021-11-28T22:48:29Z

I improved many of the project's SVGs to the best of my abilites - although I left some out, either due to minimal possible improvement or due to massive amounts of work being required.

Some things I improved

file sizes of all SVGs now add up to about 2/3rds of what they were before (0.68%)
(might be even better after the commits I've pushed after writing this, but I'm too sick to check rn)
decreased the complexity of several icons in the GUI, making rendering slightly more efficient
fixed some wonky text rendering with unusual fonts
fixed some non-compliant SVGs

Some things I messed up

I did not read the contribution guidelines until just now, so I guess only a squash merge can rescue this PR
commit titles are basically useless as well
the keyboard SVG was just too much - I did improve it, but there's still a lot of room for improvement (which I'm not willing to put my time into, I don't even know where the SVG is shown)
Some SVGs that are 'fine' are left out. Some minor compliance issues and non-optimal or empty paths remain.

…outline SVG image

qt5 didn't like the transform attribute I added previously, but this should work as well - just not as reliably. Better than before both commits in any case though

affirVega · 2021-11-30T20:49:51Z

Compiled and ran, looks like all icons are displayed correctly.

borgmanJeremy · 2021-12-02T23:33:32Z

Thanks! I'll get this checked out a bit more and then merged. Do you think we should regenerate the png's based on these new svg's?

RiedleroD · 2021-12-06T17:40:57Z

I think regenerating the PNGs won't make any difference. You're free to try, but don't say I wasted your time, @borgmanJeremy ;P

borgmanJeremy · 2021-12-08T23:40:40Z

We are going to have a beta of V11 soon, probably by the end of the weekend. Do you think this will be ready by then?

mmahmoudian · 2021-12-10T08:32:15Z

the keyboard SVG was just too much - I did improve it, but there's still a lot of room for improvement (which I'm not willing to put my time into, I don't even know where the SVG is shown)

I think you refer to the picture tgat is shown while setting a keyboard shortcut. In config when changing a keyboard shortcut a windows opens to capture what keys you press and in that windows a keyboard picture is displayed.

RiedleroD · 2021-12-12T10:39:07Z

@borgmanJeremy I think it's already ready… I originally wanted to do the rest too (except for the keyboard one) but I got sick recently & haven't fully recovered. Besides, the rest are mostly fine, just a few standard compliance issues and slightly non-optimal paths. And some empty paths. But nothing major as far as I can see. I can always open another PR later.

@mmahmoudian Yes, that's the one. Thanks! Not sure what purpose it serves though, as it kinda just sits there… Maybe a symbol of a single key would be better there? I can open a PR for that once I feel better.

mmahmoudian · 2021-12-12T10:52:29Z

@RiedleroD I hope you recover soon.

Regarding the current keyboard symbol, I'm not sure if changing it would help, but I'm personally open for suggestions

borgmanJeremy · 2021-12-20T19:31:46Z

Thanks!!

* first 3 optimizations * minified 5 more SVGs * minimized the delete icon even more * minified white variants of previously minified SVGs * removed unneccessary xml header from circlecount-outline SVG * optimized invert icons * optimized open_with SVG * optimized the alignment SVGs * optimized pin SVGs * optimized mouse-off SVGs * optimized flameshot icon SVG * optimized more instances of the flameshot icon SVG * optimized SVG 'marker' * fixed problems with weird default fonts messing with the circlecount-outline SVG image * whoops forgot to recolor a white icon * different approach to 3f73efa qt5 didn't like the transform attribute I added previously, but this should work as well - just not as reliably. Better than before both commits in any case though * somewhat decreased size & complexity of the keyboard SVG * optimized monochrome flameshot icon * optimized format-text SVG * optimized SVG icon 'graphics' * optimized SVG icon 'format_bold' * optimized SVG icon 'colorize' * optimized SVG icon 'config' * optimized icon 'redo-variant' * optimized SVG icon 'cloud-upload' * optimized SVG icon 'arrow-bottom-left' * optimized SVG icon 'circle-outline' * optimized SVG icon 'content-copy' * optimized SVG icon 'content-save' * optimized SVG icon 'cursor-move' * optimized SVG icon 'exit-to-app' * optimized SVG icon 'format_italic' * optimized SVG icon 'format_strikethrough' * optimized SVG icon 'format_underlined'

borgmanJeremy · 2021-12-22T00:21:01Z

This seems to have broken all the icons on windows so I need to revert it.

This reverts commit a00df9c.

RiedleroD · 2021-12-22T10:13:53Z

bruh what the hell
edit: I'll look into this later this week, hopefully I can fix it. Gonna need some time though, windows is not my kind of platform.

mmahmoudian · 2021-12-22T10:17:03Z

@borgmanJeremy good that you tested it before releasing the v0.11.0 It would have be chaotic in the issues section 😅

RiedleroD · 2021-12-22T10:18:18Z

do you by any chance use an old(er) version of rsvg on windows? I know it has some problems with parsing shorthand numbers in elliptical arcs, so if that could be fixed instead, that'd be cool.

edit: I know for a fact that version 2.40 has this problem bc wikipedia uses it & I always have to work around that there.

edit2: specifically this bug.

borgmanJeremy · 2021-12-22T13:09:28Z

I'll look into which version I'm using. My windows box is fully up to date and I'm using the latest qt LTS.

This reverts commit a00df9c.

borgmanJeremy · 2021-12-22T17:38:56Z

MacOs has the same issue actually.

RiedleroD · 2021-12-27T16:44:12Z

@borgmanJeremy I'm trying to test it rn but I can't compile for windows - there's no compilation documentation for windows in the readme and using the instructions for debian on WSL Ubuntu doesn't work. Logs are attached.

Can't test for MacOS because I don't have OSX at hand, but let's hope it's the same problem on both systems.

cmake.log.txt
make.log.txt

borgmanJeremy · 2021-12-27T16:48:06Z

Building on windows is a freaking a pain IMO :)

I usually download the community version of Qt and Qt Creator. Then you can open the project as a CMake project in Qt creator.

RiedleroD · 2021-12-27T21:41:46Z

@borgmanJeremy I can't get it to work... can you please build it on your end and send me the binary?

borgmanJeremy · 2021-12-27T22:26:21Z

Every pull request builds all artifacts, so if you submit a PR you can download the artifacts

RiedleroD added 17 commits November 27, 2021 18:19

first 3 optimizations

2c8646e

minified 5 more SVGs

ea3b381

minimized the delete icon even more

3a17586

minified white variants of previously minified SVGs

a4e5da9

removed unneccessary xml header from circlecount-outline SVG

82fe0f9

optimized invert icons

407e390

optimized open_with SVG

c07f1e0

optimized the alignment SVGs

531af96

optimized pin SVGs

499500c

optimized mouse-off SVGs

533649e

optimized flameshot icon SVG

c505c27

optimized more instances of the flameshot icon SVG

0b7fd57

optimized SVG 'marker'

a9054c0

fixed problems with weird default fonts messing with the circlecount-…

3f73efa

…outline SVG image

whoops forgot to recolor a white icon

38b9734

different approach to 3f73efa

adbfbee

qt5 didn't like the transform attribute I added previously, but this should work as well - just not as reliably. Better than before both commits in any case though

somewhat decreased size & complexity of the keyboard SVG

53ef15d

RiedleroD added 10 commits December 6, 2021 19:12

optimized monochrome flameshot icon

3815dd1

optimized format-text SVG

c65c80f

optimized SVG icon 'graphics'

9a1636a

optimized SVG icon 'format_bold'

af4964e

optimized SVG icon 'colorize'

7cab719

optimized SVG icon 'config'

6d3f8bc

optimized icon 'redo-variant'

2ef999a

optimized SVG icon 'cloud-upload'

b7dd339

optimized SVG icon 'arrow-bottom-left'

6b6e3c3

optimized SVG icon 'circle-outline'

33b9304

RiedleroD added 7 commits December 7, 2021 00:09

optimized SVG icon 'content-copy'

4f8d211

optimized SVG icon 'content-save'

b5e1911

optimized SVG icon 'cursor-move'

3e0ab5f

optimized SVG icon 'exit-to-app'

b8eca26

optimized SVG icon 'format_italic'

45c583e

optimized SVG icon 'format_strikethrough'

9e3e148

optimized SVG icon 'format_underlined'

c1fbc26

RiedleroD marked this pull request as ready for review December 12, 2021 10:39

borgmanJeremy approved these changes Dec 20, 2021

View reviewed changes

borgmanJeremy merged commit a00df9c into flameshot-org:master Dec 20, 2021

borgmanJeremy added a commit that referenced this pull request Dec 22, 2021

Revert "Optimize various SVGs (#2130)"

5dedb10

This reverts commit a00df9c.

borgmanJeremy mentioned this pull request Dec 22, 2021

Revert "Optimize various SVGs" #2179

Merged

borgmanJeremy added a commit that referenced this pull request Dec 22, 2021

Revert "Optimize various SVGs (#2130)" (#2179)

9752b97

This reverts commit a00df9c.

RiedleroD mentioned this pull request Jan 24, 2022

Optimize various SVGs (second try) #2318

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize various SVGs #2130

Optimize various SVGs #2130

RiedleroD commented Nov 28, 2021 •

edited

Loading

affirVega commented Nov 30, 2021 •

edited

Loading

borgmanJeremy commented Dec 2, 2021

RiedleroD commented Dec 6, 2021

borgmanJeremy commented Dec 8, 2021

mmahmoudian commented Dec 10, 2021

RiedleroD commented Dec 12, 2021 •

edited

Loading

mmahmoudian commented Dec 12, 2021

borgmanJeremy commented Dec 20, 2021

borgmanJeremy commented Dec 22, 2021 •

edited

Loading

RiedleroD commented Dec 22, 2021 •

edited

Loading

mmahmoudian commented Dec 22, 2021

RiedleroD commented Dec 22, 2021 •

edited

Loading

borgmanJeremy commented Dec 22, 2021

borgmanJeremy commented Dec 22, 2021

RiedleroD commented Dec 27, 2021

borgmanJeremy commented Dec 27, 2021

RiedleroD commented Dec 27, 2021 •

edited

Loading

borgmanJeremy commented Dec 27, 2021

Optimize various SVGs #2130

Optimize various SVGs #2130

Conversation

RiedleroD commented Nov 28, 2021 • edited Loading

affirVega commented Nov 30, 2021 • edited Loading

borgmanJeremy commented Dec 2, 2021

RiedleroD commented Dec 6, 2021

borgmanJeremy commented Dec 8, 2021

mmahmoudian commented Dec 10, 2021

RiedleroD commented Dec 12, 2021 • edited Loading

mmahmoudian commented Dec 12, 2021

borgmanJeremy commented Dec 20, 2021

borgmanJeremy commented Dec 22, 2021 • edited Loading

RiedleroD commented Dec 22, 2021 • edited Loading

mmahmoudian commented Dec 22, 2021

RiedleroD commented Dec 22, 2021 • edited Loading

borgmanJeremy commented Dec 22, 2021

borgmanJeremy commented Dec 22, 2021

RiedleroD commented Dec 27, 2021

borgmanJeremy commented Dec 27, 2021

RiedleroD commented Dec 27, 2021 • edited Loading

borgmanJeremy commented Dec 27, 2021

RiedleroD commented Nov 28, 2021 •

edited

Loading

affirVega commented Nov 30, 2021 •

edited

Loading

RiedleroD commented Dec 12, 2021 •

edited

Loading

borgmanJeremy commented Dec 22, 2021 •

edited

Loading

RiedleroD commented Dec 22, 2021 •

edited

Loading

RiedleroD commented Dec 22, 2021 •

edited

Loading

RiedleroD commented Dec 27, 2021 •

edited

Loading