Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arrow tool glitches #2395

Merged
merged 1 commit into from
Feb 13, 2022
Merged

fix: arrow tool glitches #2395

merged 1 commit into from
Feb 13, 2022

Conversation

UnkwUsr
Copy link
Contributor

@UnkwUsr UnkwUsr commented Feb 8, 2022

Demo (on the left is fixed version, on the right is original flameshot):

demo_flameshot_bug_fix.mp4

@UnkwUsr
Copy link
Contributor Author

UnkwUsr commented Feb 8, 2022

Also check comment in code. The problem is that if we set length to 0, then "line" will be just 1 "pixel" (but real size is much bigger, because we set pen size before, in function ArrowTool::process (code block attached)), so we lose information about angle.

painter.setPen(QPen(color(), size()));

@borgmanJeremy borgmanJeremy merged commit db94616 into flameshot-org:master Feb 13, 2022
@borgmanJeremy
Copy link
Contributor

Thanks!

panpuchkov pushed a commit to namecheap/flameshot that referenced this pull request May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants