Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pinwidget: allow copying to clipboard and saving to file #2519

Merged
merged 1 commit into from
Apr 7, 2022
Merged

pinwidget: allow copying to clipboard and saving to file #2519

merged 1 commit into from
Apr 7, 2022

Conversation

zhangfuwen
Copy link
Contributor

add a context menu in pinwidget for copying to clipboard and saving to file

@mmahmoudian
Copy link
Member

mmahmoudian commented Apr 2, 2022 •
edited
Loading

This addresses #1007 and consequently part of #954

@borgmanJeremy
Copy link
Contributor

@mmahmoudian @veracioux what do you think of the way the menu is implemented. I wonder if instead we should show "purple bubbles" around the pin like the main menu.

@zhangfuwen Thank you for working on this!! It's a highly requested feature.

@veracioux
Copy link
Contributor

@borgmanJeremy I agree that we should show purple bubbles, but the best, most consistent and maintainable way to do that is by adding a context menu item that turns the pin widget into a windowed capture GUI.

But for now, I like the context menu implemented in this PR.

@zhangfuwen zhangfuwen force-pushed the pinwidget_copy_save branch from 506c536 to 7086f2d Compare April 6, 2022 12:39
@borgmanJeremy borgmanJeremy merged commit db5f8a7 into flameshot-org:master Apr 7, 2022
@zhangfuwen zhangfuwen deleted the pinwidget_copy_save branch April 7, 2022 02:04
@Alaskra
Copy link
Contributor

Alaskra commented Apr 13, 2022

2022-04-13_22-39
When I try to save the pinned picture, the pinned picture covers the file manager and I can't move it away.

@Alaskra
Copy link
Contributor

Alaskra commented Apr 13, 2022

I think we should switch off the Qt::WindowStaysOnTopHint option, and then switch on after save.

@Alaskra Alaskra mentioned this pull request Apr 15, 2022
Merged
panpuchkov pushed a commit to namecheap/flameshot that referenced this pull request May 13, 2022
@zhangfuwen
pinwidget: allow copying to clipboard and saving to file (flameshot-o…
d780449 
…rg#2519)

Co-authored-by: zhangfuwen <zhangfuwen@foxmail.com>
(cherry picked from commit db5f8a7)
@toofar toofar mentioned this pull request Jul 30, 2022
Closed
@mmahmoudian mmahmoudian mentioned this pull request Jul 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borgmanJeremy borgmanJeremy borgmanJeremy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhangfuwen @mmahmoudian @borgmanJeremy @veracioux @Alaskra