Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev bubble pointers #2638

Merged
merged 9 commits into from
Jun 2, 2022
Merged

Dev bubble pointers #2638

merged 9 commits into from
Jun 2, 2022

Conversation

vozdeckyl
Copy link
Contributor

Issue #2623.

@borgmanJeremy
Copy link
Contributor

Thanks! Code looks good and the behavior feels right. The fact that it doesnt draw until you pull the cursor outside the bubble makes the behavior the same for users who do not want to draw the arrow.

@borgmanJeremy borgmanJeremy merged commit 7a57268 into flameshot-org:master Jun 2, 2022
@borgmanJeremy borgmanJeremy mentioned this pull request Jun 2, 2022
Closed
panpuchkov pushed a commit to namecheap/flameshot that referenced this pull request Jun 12, 2022
@vozdeckyl
Dev bubble pointers (flameshot-org#2638)
c5d71bc 
* adding a simple line as a test

* replacing line with pointer

* remove commented out lines

* code format

* fixed the 'QPainterPath path' error

* make pointers more pointy

* comment and variable name

Co-authored-by: Mehrad Mahmoudian <m.mahmoudian@gmail.com>
(cherry picked from commit 7a57268)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borgmanJeremy borgmanJeremy borgmanJeremy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vozdeckyl @borgmanJeremy @mmahmoudian