Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of the plugin framework #3661

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Initial implementation of the plugin framework #3661

wants to merge 3 commits into from

Conversation

jack9603301
Copy link
Contributor

@jack9603301 jack9603301 commented Jul 5, 2024 •
edited
Loading

@jack9603301
Initial implementation of the plugin framework
650f7c0 
Plugin RFC flameshot-org#2529

Signed-off-by: Ouyang Chunhui <jack9603301@163.com>
@jack9603301 jack9603301 force-pushed the feature/plugin-RFC branch from 5286322 to 650f7c0 Compare July 5, 2024 09:40
@mmahmoudian mmahmoudian requested a review from veracioux July 5, 2024 09:53
mmahmoudian
mmahmoudian reviewed Jul 5, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@jack9603301 jack9603301 force-pushed the feature/plugin-RFC branch from 0c095b4 to e9e13dc Compare July 5, 2024 10:14
@jack9603301
Copy link
Contributor Author

This framework will introduce a new dependency: yaml-cpp

@jack9603301 jack9603301 force-pushed the feature/plugin-RFC branch from e9e13dc to 0bf17e0 Compare July 5, 2024 10:32
@jack9603301
PDF and printer support are not enabled by default
66327f9 
This is to counter PR checks, because it seems that the PR's qt environment does not support some specific parameters of this function - the latest version of qt5 compiles fine on Linux

Signed-off-by: Ouyang Chunhui <jack9603301@163.com>
@jack9603301 jack9603301 force-pushed the feature/plugin-RFC branch from 0bf17e0 to 66327f9 Compare July 5, 2024 10:34
@jack9603301 jack9603301 requested a review from mmahmoudian July 5, 2024 11:03
@jack9603301
This is experimental
d8d9842 
Since the plugin manager is an experimental feature, the compilation flag is turned off by default.

Signed-off-by: Ouyang Chunhui <jack9603301@163.com>
@mmahmoudian mmahmoudian requested a review from panpuchkov July 11, 2024 10:58
@jack9603301
Copy link
Contributor Author

@panpuchkov Can you take a look at this PR?

@panpuchkov
Copy link
Contributor

If we go with a plugin system, why do we need to have multiple #ifdef USE_PRINTER_SUPPORT, it looks weird.
If we don't want to have it as a built-in option and want to have a build option to include it or not, this is the case where it should be as a plugin.

@jack9603301
Copy link
Contributor Author

If we go with a plugin system, why do we need to have multiple #ifdef USE_PRINTER_SUPPORT, it looks weird.
If we don't want to have it as a built-in option and want to have a build option to include it or not, this is the case where it should be as a plugin.

In fact, this release has two features, one is plug-in support, and the other is a small patch that supports flameshot to send images directly to the printer.

You will find that these two are independent, and you are free to start either one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veracioux veracioux Awaiting requested review from veracioux

@mmahmoudian mmahmoudian Awaiting requested review from mmahmoudian

@panpuchkov panpuchkov Awaiting requested review from panpuchkov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jack9603301 @panpuchkov @mmahmoudian