-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting pin border width (or removing it) #622
Conversation
6085f00
to
d9ca550
Compare
b496f8c
to
e1b282a
Compare
e1b282a
to
a4d0414
Compare
Looks fine to me but I'm not yet experienced enough to decide I think. @borgmanJeremy should we merge? |
I guess this is not a bad thing to add but we should keep in mind that adding individual settings for specific tools might bloat the config GUI. I know there is demand for a few additional settings for specific tools. What I was thinking to add is that every tool would have a config widget. When you click the name of the tool (not the checkbox) it would show the specific widget with the settings for that tool in a contextual fashion. |
Lets roll this in with the discussions on #954 |
Just wanna iterate on some of these ideas:
If we did have per-tool settings be related to the selection menu, I think instead of clicking the name, we should display a settings icon (like a cog or a wrench) that floats to the right of the menu, in the yellowed-out area of this screenshot for example: The user would click this instead of the checkbox/label, just to make things clear (since the primary goal of this checkbox list here is to enable/disable tools, which could cause confusion). However, this still has a few problems. For example, users trying to find tool-specific settings in this screen would probably not think to look in the Interface tab. They'd probably check General or Filename Editor first. Having it be in the Button Selection group only makes sense because that's the only existing setting that deals with tools, but it kinda doesn't make sense otherwise. I think a far better solution is just to have a new tab related to the tools, or a group in General for them. Putting a tool-settings group in general might make sense, since there does appear to be some whitespace there: However, I think a new tab is best, since there are a few other tools that could use settings (like upload to control different upload destinations, Text to control font, Marker to control opacity, etc) |
Closing this for now. I would like to see this reworked after we add per tool configs. |
addresses #554