Feature/lock keeper daemon #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osantana85
reviewed
Oct 27, 2021
| return lockAcquiredForMillis - lockRefreshMarginMillis; | ||
| } | ||
|
|
||
| // return lockExpiresAt != null |
| lockQuitTryingAfterMillis, | ||
| lockTryFrequencyMillis, | ||
| lockRefreshMarginMillis); | ||
| lockManager.initialize(); |
Member
There was a problem hiding this comment.
Why do we need initialize method now? I think we can just include its code inside DefaultLockManager constructor, and remove "initialize" method, as we only are initializing "lockDaemon" and "shouldStopTryingAt" value.
Member
Author
There was a problem hiding this comment.
initialize starts the htread. I don't like to have that in a constructor., even less if we pass the this instance to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.