-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUILDS: Use vendor directory instead of Godeps #438
Conversation
a800802
to
b656587
Compare
Kind of blocked on #407 which is blocked on someone finding the time to do some GCE testing. |
@@ -1,7 +1,6 @@ | |||
language: go | |||
go: | |||
- 1.4 | |||
- 1.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably be testing with 1.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and then add GO15VENDOREXPERIMENT=1
as an environment variable
Keep the Godeps.json but store files in the vendor directly. This means that there is no longer a need to rewrite import paths.
Project hosting provider code.google.com was shutdown beginning of this year. This updates code.google.com dependencies. Minor changes were required for oauth in GCE module.
OK, this is updated to move to glide. This was much easier for me to get working than Godep. (See coreos/docs#775 for general CoreOS support for migrating to glide) This fairly large PR also updates some upstream deps which have been removed (the Google code ones) and update vishvanda/netlink It updates the travis.yaml file to make it very similar to the CNI one. The crucial change is removal of Go 1.4 support (since a vendor directory is now being used) @steveej / @philips Can I get a LGTM so I can get this merged? |
I've verified that this fixes the vxlan port number problem. |
Closes #407