-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execute ModuleRun tasks of the same weight in parallel #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miklezzzz
force-pushed
the
apply-modules-simultaneously
branch
11 times, most recently
from
September 10, 2024 15:36
033a95a
to
b6c26de
Compare
miklezzzz
changed the title
Apply modules` releases simultaneously if possible
Execute ModuleRun tasks of the same weight in parallel
Sep 10, 2024
an example of grouped (parallel) run:
|
a failed task in a grouped run
|
yet another example:
|
yalosev
reviewed
Sep 23, 2024
yalosev
reviewed
Sep 23, 2024
yalosev
reviewed
Sep 23, 2024
Also, there is a |
makes sense |
|
yalosev
approved these changes
Sep 26, 2024
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com> add group queues Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
miklezzzz
force-pushed
the
apply-modules-simultaneously
branch
from
September 26, 2024 15:04
8a2c374
to
eecd106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
ModuleRun
tasks and correspondingModuleHookRun
tasks for modules of the same order (weight) are executedin parallel
inparallel
queues. There are 10parallel
queues by default in the operator's queue set.What this PR does / why we need it
This pr adds new type of tasks -
ParallelModuleRun
. A task of this type represents a group of smaller tasks with the same order/weight ofModuleRun
andModuleHookRun
types. These subordinate tasks are executed in parallel pre-created namedparallel_queue_x
queues and all the results and errors are propagated back to the correspondingParallelModuleRun
task that updates its status accordingly.Special notes for your reviewer