reinit helm3lib action config on global hook module reload #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
yalosev
approved these changes
Sep 26, 2024
name212
pushed a commit
that referenced
this pull request
Sep 30, 2024
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com> (cherry picked from commit 1d2364e)
name212
pushed a commit
that referenced
this pull request
Sep 30, 2024
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com> (cherry picked from commit 1d2364e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If helm3lib is in use, reinit its action configuration every time a global hook provokes reconverge of all modules, cause we need to refresh helm's client capabilities in case of such a global change like kubernetes version upgrade.
What this PR does / why we need it
We need it to keep helm's client capabilities list up-to-date.
Special notes for your reviewer