[module-manager] Disable modules hooks correctly #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
yalosev
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates a hook storage's
cleanmethod to reset thecontrollersReadyflag to false every time the module is disabled.Also, contains a small fix to the scheduler's method.
What this PR does / why we need it
Without resetting the
controllersReadyflag when a module is disabled, there is a possibility to catch a panic next time the module is enabled, as the module's hooks have to get their hooks controllers set before they can be safely evoked. ThecontrollersReadyhelps avoid evoking a hook which hook controller hasn't been set yet.Special notes for your reviewer