Feat/load config interface #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 13, 2024 19:48
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
ldmonster
force-pushed
the
feat/load-config-interface
branch
from
46282ee to
06298c8
Compare
added 2 commits
December 16, 2024 11:24
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
added 2 commits
December 16, 2024 12:49
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
added 9 commits
December 19, 2024 21:29
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
miklezzzz
approved these changes
Dec 20, 2024
yalosev
approved these changes
Dec 23, 2024
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add interface between module/globalConfig and hooks to get options.
What this PR does / why we need it
Incapsulate options logic in hook
Special notes for your reviewer