Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for returning plots instead of showing them directly #68

Merged
merged 3 commits into from
Dec 17, 2023
Merged

Support for returning plots instead of showing them directly #68

merged 3 commits into from
Dec 17, 2023

Conversation

devbrones
Copy link
Contributor

Opening pr because i think this would be useful functionality.

@flaport
Copy link
Owner

flaport commented Dec 17, 2023

Hi! Thanks for your PR :)

I like the idea, but I made a few changes that make it better in my opinion:

  1. Every plotting function now always returns the figure (no need for a flag)
  2. You can disable the plt.show call by setting the show flag to False in each plotting function.
  3. I like the idea of being able to set a style, so I added a style flag to each plotting function. However, I think the default should be None. You're free to call with your own custom styles on your side :)

@flaport flaport merged commit ff36719 into flaport:master Dec 17, 2023
2 of 3 checks passed
@flaport
Copy link
Owner

flaport commented Dec 17, 2023

changes will be available in fdtd>=0.3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devbrones @flaport