Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(orm): implement dependencies for migrations #79

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

m4tx
Copy link
Contributor

@m4tx m4tx commented Nov 26, 2024

For now the system only really create dependency on the previous migration in the app. Eventually we'll extend this to handle ForeignKeys and other relationship types as well.

rustfmt.toml Show resolved Hide resolved
For now the system only really create dependency on the previous
migration in the app. Eventually we'll extend this to handle ForeignKeys
and other relationship types as well.
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
flareon/src/db/migrations/sorter.rs 96.36% 12 Missing ⚠️
flareon-cli/src/migration_generator.rs 84.05% 11 Missing ⚠️
flareon/src/db/migrations.rs 90.90% 3 Missing ⚠️
flareon/src/lib.rs 0.00% 1 Missing ⚠️
Flag Coverage Δ
rust 83.99% <94.11%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
flareon/src/db.rs 91.32% <ø> (ø)
flareon/src/test.rs 95.65% <100.00%> (+0.53%) ⬆️
flareon/src/lib.rs 57.57% <0.00%> (ø)
flareon/src/db/migrations.rs 85.82% <90.90%> (+0.14%) ⬆️
flareon-cli/src/migration_generator.rs 71.02% <84.05%> (+1.88%) ⬆️
flareon/src/db/migrations/sorter.rs 96.36% <96.36%> (ø)

@m4tx m4tx requested review from seqre and Iipin November 26, 2024 20:57
Copy link
Contributor

@seqre seqre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

flareon/src/db/migrations.rs Show resolved Hide resolved
rustfmt.toml Show resolved Hide resolved
@m4tx m4tx merged commit e1c11ed into master Nov 27, 2024
23 checks passed
@m4tx m4tx deleted the migration-deps branch November 27, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants