Fix Select-based setting breaking admin pages #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SychO9
reviewed
Jul 21, 2021
There was a problem hiding this comment.
Looks good, though there is still another issue with the Select component changes, the select in Mail page for example is lacking the default className,
This is the relevant code, it seems like the provided additional className overrides the default one, while before the changes to Select component, it ignored it, idk why that class is provided, it doesn't make sense to have there, I'd remove it entirely (from both inputs).
SychO9
force-pushed
the
dw/fix-admin-errors
branch
from
da80923 to
f5b3e73
Compare
SychO9
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug caused by #2959
Changes proposed in this pull request:
Prevents some attrs being passed to the
<Select>component when they should not be.For example,
type: "select"creates a Select component, but thistypeattr was also passed to the component, resulting in Mithril attempting to perform weird changes on elements which are then disallowed by the DOM engine, causing the page to error.Reviewers should focus on:
Are there other areas broken by the Select change? Extension setting pages seem to be fine when using these changes.
Screenshot
Confirmed
Backend changes: tests are green (runcomposer test).