-
-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aria-label attribute to navigation drawer button. #3157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
We'll need to use Flarum's translator for this.
Could you add a key in the core.yml
file inside the locale folder (make sure it's added in the correct place alphabetically), then get the text with app.translator.trans('core.<key>')
in the JS.
The best place would be under core.lib
:
Got it, thanks @davwheat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, ariaLabel
also needs to be aria-label
. Missed that when looking on my phone.
Co-authored-by: David Wheatley <hi@davwheat.dev>
…tion.js Co-authored-by: David Wheatley <hi@davwheat.dev>
Changes proposed in this pull request:
Adds
aria-label
attribute to navigation drawer button to improve accessibility and satisfy this warning in Chrome.Reviewers should focus on:
Affects every page that the navigation drawer button is visible.
Necessity
Confirmed
composer test
).