Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): add accessible labels to notification grid options #3520

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Jul 11, 2022

Fixes #3369

Changes proposed in this pull request:

  • adds a11y labels to the notification grid

image

Reviewers should focus on:

Is there a better way this label could be written?

Screenreaders will announce, for example, checkbox. receive "someone renames a discussion i started" notifications via web. ticked.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added the type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) label Jul 11, 2022
@davwheat davwheat requested a review from SychO9 July 11, 2022 08:15
@davwheat davwheat self-assigned this Jul 11, 2022
@davwheat davwheat added this to the 1.5 milestone Jul 11, 2022
@davwheat davwheat merged commit 952a589 into main Jul 14, 2022
@davwheat davwheat deleted the dw/3369-notif-grid-a11y branch July 14, 2022 11:02
@luceos luceos mentioned this pull request Jul 30, 2022
@luceos luceos mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11Y] Notifications list switches missing accessible labels
2 participants