Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: convert Badge Checkbox and Navigation components to TS #3532

Merged
merged 4 commits into from
Jul 14, 2022
Merged

refactor: convert Badge Checkbox and Navigation components to TS #3532

merged 4 commits into from
Jul 14, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jul 14, 2022 •
edited
Loading

Part of #3533

Changes proposed in this pull request:

  • Converts the Badge component and inheritors to TypeScript.
  • Converts the Checkbox component and inheritors to TypeScript.
  • Converts the Navigation component to TypeScript.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

SychO9 added 3 commits July 12, 2022 13:59
@SychO9
chore: convert badge components to TypeScript
286d7be 
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
@SychO9
chore: convert checkbox components to TypeScript
0967018 
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
@SychO9
chore: convert Navigation component to TypeScript
1589730 
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
@SychO9 SychO9 added this to the 1.5 milestone Jul 14, 2022
@SychO9 SychO9 requested a review from davwheat July 14, 2022 10:12
@SychO9 SychO9 self-assigned this Jul 14, 2022
@SychO9 SychO9 changed the title chore: convert Badge Checkbox and Navigation components to TS refactor: convert Badge Checkbox and Navigation components to TS Jul 14, 2022
@SychO9 @davwheat
chore: import mithril type instead
1e3b334 
Co-authored-by: David Wheatley <hi@davwheat.dev>
@davwheat davwheat merged commit 7471ef6 into main Jul 14, 2022
@davwheat davwheat deleted the sm/covert-some-core-components-to-ts branch July 14, 2022 14:54
@luceos luceos mentioned this pull request Jul 30, 2022
Closed
@luceos luceos mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

Assignees

@SychO9 SychO9

Labels
type/cleanup
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@SychO9 @davwheat