Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: convert page components to TypeScript #3538

Merged
merged 2 commits into from
Aug 8, 2022
Merged

refactor: convert page components to TypeScript #3538

merged 2 commits into from
Aug 8, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jul 16, 2022 •
edited by davwheat
Loading

Part of #3533

Changes proposed in this pull request:

  • Sneaked in an a11y fix. (won't squash merge).
  • Converts all JS page components to TS.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 added this to the 1.5 milestone Jul 16, 2022
@SychO9 SychO9 requested a review from davwheat July 16, 2022 10:34
@SychO9
fix(a11y): color preview fields have no aria label
8c9066d 
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
@SychO9 SychO9 force-pushed the sm/convert-core-components-to-ts-3 branch from fa8bdca to 4a8973e Compare July 19, 2022 18:29
@SychO9 @davwheat
refactor: convert page components to TypeScript
6e1efd1 
Co-authored-by: David Wheatley <hi@davwheat.dev>
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
@SychO9 SychO9 force-pushed the sm/convert-core-components-to-ts-3 branch from 4a8973e to 6e1efd1 Compare July 19, 2022 18:30
@SychO9 SychO9 requested a review from davwheat July 19, 2022 18:38
@SychO9
Copy link
Member Author

SychO9 commented Aug 8, 2022

@davwheat friendly poke :)

@SychO9 SychO9 merged commit 1948f25 into main Aug 8, 2022
@SychO9 SychO9 deleted the sm/convert-core-components-to-ts-3 branch August 8, 2022 21:11
@luceos luceos mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

Assignees
No one assigned
Labels
type/cleanup
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@SychO9 @davwheat