Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: extensibility improvements #3729

Merged
merged 7 commits into from
Apr 16, 2023
Merged

chore: extensibility improvements #3729

merged 7 commits into from
Apr 16, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Feb 10, 2023

Changes proposed in this pull request:

  • Improves extensibility of some components based on recent experience trying to extend them.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

SychO9 added 5 commits January 21, 2023 16:45
@SychO9
chore: improve tags page extensibility
3a9d58c 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
chore: improve discussion list item extensibility
da789eb 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
chore: improve change password modal extensibility
f06659d 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
chore: item-listify tags page
4fa73f3 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
chore: item-listify change email modal
285d3aa 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner February 10, 2023 22:09
@SychO9 SychO9 added the javascript Pull requests that update Javascript code label Feb 11, 2023
@SychO9
Merge branch 'main' into sm/extensibility-improvements
1f84074 
# Conflicts:
#	framework/core/js/src/forum/components/DiscussionListItem.tsx
@SychO9
chore: simplify data flow
cf74431 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
askvortsov1
askvortsov1 approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good refactor to me, I like simpler view functions

@SychO9 SychO9 added this to the 1.8 milestone Apr 16, 2023
@SychO9 SychO9 merged commit b89a01c into main Apr 16, 2023
@SychO9 SychO9 deleted the sm/extensibility-improvements branch April 16, 2023 20:05
@rob006 rob006 mentioned this pull request Apr 16, 2023
Open
@github-actions github-actions bot mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code type/extensibility
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
2 participants
@SychO9 @askvortsov1