Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unread count in post stream not visible #3791

Merged
merged 1 commit into from
Apr 16, 2023
Merged

fix: unread count in post stream not visible #3791

merged 1 commit into from
Apr 16, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Apr 15, 2023

Fixes #3642

Changes proposed in this pull request:
Removes the overflow hidden CSS rule. Applies a 0 opacity when the unread is 0.
Visually the unread label never seems to overlap with the text above it, so it seems fine.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner April 15, 2023 13:56
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoah, simple fix for a very old bug!

Maybe we should use css visibility for semantic simplicity? Or conditionally add display: none?

@SychO9
Copy link
Member Author

SychO9 commented Apr 16, 2023

unfortunately, visibility and display just don't work out well, maybe because of how jQuery does the animation.

@SychO9 SychO9 merged commit 11aa7bb into main Apr 16, 2023
@SychO9 SychO9 deleted the sm/3642 branch April 16, 2023 20:14
@github-actions github-actions bot mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unread is not visible in navigation sidebar
2 participants