Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): reply placeholder not accessible #3793

Merged
merged 1 commit into from
Apr 16, 2023
Merged

fix(a11y): reply placeholder not accessible #3793

merged 1 commit into from
Apr 16, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Apr 15, 2023

Fixes #3659

Changes proposed in this pull request:

  • Makes the placeholder into a button.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9
fix(a11y): reply placeholder not accessible
3f35958 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner April 15, 2023 17:43
@SychO9 SychO9 modified the milestone: 1.8 Apr 15, 2023
askvortsov1
askvortsov1 approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I'm assuming this is tested locally, but might be nice for review to have before/after screenshots to ensure that nothing has changed

@SychO9
Copy link
Member Author

SychO9 commented Apr 16, 2023

Yup, the style is not changed at all. Just the semantics.

@SychO9 SychO9 merged commit aa33cfd into main Apr 16, 2023
@SychO9 SychO9 deleted the sm/3659 branch April 16, 2023 20:13
@github-actions github-actions bot mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Reply placeholder" is not focusable and is missing a role="button"
2 participants
@SychO9 @askvortsov1