Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deleting a discussion from the profile does not visually remove it #3799

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Apr 16, 2023

Fixes #2233

Changes proposed in this pull request:

  • Based on previous PRs, I think the best approach to this is as Clark suggested. An event-listener approach, so that any discussion list that deletes a discussion, affects all discussion list states.
  • This is cleaner than previous PRs.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner April 16, 2023 15:09
@imorland imorland added this to the 1.8 milestone Apr 19, 2023
@imorland imorland added javascript Pull requests that update Javascript code type/bug labels Apr 19, 2023
@imorland imorland merged commit 297a2d8 into main Apr 19, 2023
@imorland imorland deleted the sm/2233-alternate branch April 19, 2023 11:37
@github-actions github-actions bot mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] UI does't get refreshed if a discussion is deleted from the Discussions tab of the user profile
2 participants