Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore[tags]: Change some methods from private to protected, to be able to extend the affected classes #3802

Merged
merged 1 commit into from
Apr 21, 2023
Merged

chore[tags]: Change some methods from private to protected, to be able to extend the affected classes #3802

merged 1 commit into from
Apr 21, 2023

Conversation

iPurpl3x
Copy link
Contributor

Changes proposed in this pull request:
see title

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@iPurpl3x iPurpl3x requested a review from a team as a code owner April 20, 2023 13:10
@luceos
Copy link
Member

luceos commented Apr 20, 2023

@iPurpl3x out of curiosity, did you check the check boxes intended for maintainers? 🙈

@imorland imorland changed the title Change some methods from private to protected, to be able to extend the affected classes chore[tags]: Change some methods from private to protected, to be able to extend the affected classes Apr 21, 2023
@imorland imorland added this to the 1.8 milestone Apr 21, 2023
imorland
imorland approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason to not accept this PR, however be warned that much is likely to change here after the next release as we prepare for 2.0

@imorland imorland merged commit 1d20f4d into flarum:main Apr 21, 2023
@iPurpl3x
Copy link
Contributor Author

iPurpl3x commented May 2, 2023

@luceos I guess I did, but it wasn't clear to me whether I or a maintainer should check those checkboxes…

@github-actions github-actions bot mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
type/extensibility
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@iPurpl3x @luceos @imorland