Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mentions): mentions XHR fired even after mentioning is done #3806

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Apr 24, 2023

Fixes #3766

Changes proposed in this pull request:

  • Only executes logic if the typed content so far has an ongoing mention format typing.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

SychO9 added 2 commits April 24, 2023 16:29
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner April 24, 2023 15:33
@SychO9 SychO9 requested a review from imorland April 24, 2023 15:34
@imorland imorland merged commit accdfde into main Apr 24, 2023
@imorland imorland deleted the sm/3766-mentions-non-stop-ajax branch April 24, 2023 16:57
@imorland imorland added this to the 1.8 milestone Apr 24, 2023
@imorland imorland added type/bug javascript Pull requests that update Javascript code labels Apr 24, 2023
@github-actions github-actions bot mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mentions fire xhr after completing the mentions element
2 participants