Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a trait to flush the formatter cache in tests #3811

Merged
merged 2 commits into from
Apr 30, 2023
Merged

feat: add a trait to flush the formatter cache in tests #3811

merged 2 commits into from
Apr 30, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Apr 27, 2023

Fixes #3663

Changes proposed in this pull request:

  • Adds a trait that can be used in tests to clear formatter cache when needed.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

SychO9 and others added 2 commits April 27, 2023 22:08
@SychO9 SychO9 requested a review from a team as a code owner April 27, 2023 21:42
@SychO9 SychO9 merged commit 7298ccb into main Apr 30, 2023
@SychO9 SychO9 deleted the sm/3663-clear-formatter-cache-in-tests branch April 30, 2023 08:48
@github-actions github-actions bot mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luceos luceos luceos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[testing] Formatter cache is not cleared after tests
3 participants
@SychO9 @luceos @StyleCIBot