Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bbcode): highlight.js does not work after changing post content #3817

Merged
merged 3 commits into from
May 2, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Apr 30, 2023

Fixes #3794

Changes proposed in this pull request:

  • Explicitly applies hljs after the post content has been updated.
  • The relevant commit is 8081e9b the second one is just a re-organization of the code.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

SychO9 and others added 3 commits April 30, 2023 19:16
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner April 30, 2023 18:34
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable as a fix for v1.8, but I think that for 2.0 we should really try to explicitly run hljs in the frontend (or adopt @n-peugnet's approach in the linked issue), so that we can turn on CSP

@SychO9
Copy link
Member Author

SychO9 commented Apr 30, 2023

Agreed.

@imorland imorland added this to the 1.8 milestone May 2, 2023
@imorland imorland merged commit d7fcd8a into main May 2, 2023
@imorland imorland deleted the sm/3794-hljs-fix branch May 2, 2023 08:39
@github-actions github-actions bot mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code syntax highlighting bug
4 participants