Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migration: js to tsx] HeaderPrimary.js converted to HeaderPrimary.tsx #4052

Merged
merged 3 commits into from
Oct 2, 2024
Merged

[Migration: js to tsx] HeaderPrimary.js converted to HeaderPrimary.tsx #4052

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0952971
HeaderPrimary.js converted to HeaderPrimary.tsx
ksvijayan06 Oct 1, 2024
eb6ea8b
import Mithril at the top
ksvijayan06 Oct 2, 2024
4e255ec
chore: format
SychO9 Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .../js/src/forum/components/HeaderPrimary.js → ...js/src/forum/components/HeaderPrimary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import listItems from '../../common/helpers/listItems';
* default skin, these are shown just to the right of the forum title.
*/
export default class HeaderPrimary extends Component {
view() {
view(): JSX.Element {
return <ul className="Header-controls">{listItems(this.items().toArray())}</ul>;
}

Expand All @@ -16,7 +16,8 @@ export default class HeaderPrimary extends Component {
*
* @return {ItemList<import('mithril').Children>}
*/
items() {
return new ItemList();

items(): ItemList<import('mithril').Children> {
return new ItemList<import('mithril').Children>();
SychO9 marked this conversation as resolved.
Show resolved Hide resolved
}
}