Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot cast as json on mariadb 10 #4110

Merged
merged 4 commits into from
Nov 15, 2024
Merged

fix: cannot cast as json on mariadb 10 #4110

merged 4 commits into from
Nov 15, 2024

Conversation

luceos
Copy link
Member

@luceos luceos commented Nov 13, 2024

Fixes #4109

@luceos luceos requested a review from SychO9 November 13, 2024 14:44
@luceos luceos requested a review from a team as a code owner November 13, 2024 14:44
@luceos luceos added this to the 2.0 milestone Nov 13, 2024
SychO9
SychO9 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I just figured out why the tests didn't fail before. It's because they aren't running the migration, they are running the 2.x installation dump which is faster.

@SychO9 SychO9 merged commit 6323314 into 2.x Nov 15, 2024
28 checks passed
@SychO9 SychO9 deleted the dk/2.x-mariadb-json-migration-fix branch November 15, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

Assignees

@luceos luceos

Labels
type/regression
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

[2.x] Cast as JSON not possible
3 participants
@luceos @SychO9 @StyleCIBot