[1.x] chore(core, tags): resolve a11y
warnings in Admin Frontend
#4114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #3360
The Permission Scope Removal -and Edit Tag Buttons don't have content or an a11y label, which resulted in a bunch of warnings being logged in the console on those pages, which is a minor nuisance while developing/debugging the admin frontend.
Changes proposed in this pull request:
This PR adds the
aria-label
attribute to two different Buttons, which were the cause for the Flarum Accessibility Warnings and improves QOL for extension developers.Reviewers should focus on:
Screenshot
Necessity
Confirmed
composer test
).Required changes: