Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] chore(core, tags): resolve a11y warnings in Admin Frontend #4114

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Nov 15, 2024

Progresses #3360
The Permission Scope Removal -and Edit Tag Buttons don't have content or an a11y label, which resulted in a bunch of warnings being logged in the console on those pages, which is a minor nuisance while developing/debugging the admin frontend.

Screenshot 2024-11-15 at 11 48 33

Changes proposed in this pull request:
This PR adds the aria-label attribute to two different Buttons, which were the cause for the Flarum Accessibility Warnings and improves QOL for extension developers.

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca marked this pull request as ready for review November 15, 2024 11:32
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner November 15, 2024 11:32
@imorland imorland added this to the 1.8.9 milestone Nov 18, 2024
@imorland imorland added javascript Pull requests that update Javascript code type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) labels Nov 18, 2024
@imorland imorland merged commit 3450232 into flarum:1.x Nov 19, 2024
274 checks passed
@imorland imorland deleted the di/fix-a11y-in-admin branch November 19, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants