Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] fix: change length of email field #4117

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Nov 18, 2024

1.x pendent to #4118

Fixes #0000
It appears as if the email validator allows 254 chars for the entire email, while the DB field only allows 150. This results in email addresses simply being truncated without any error message when creating users with longer email addresses.

Changes proposed in this pull request:
Increase length of email field to 254 chars to match the validator

Reviewers should focus on:
See https://www.rfc-editor.org/errata/eid1690

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@imorland imorland added this to the 1.8.9 milestone Nov 18, 2024
@DavideIadeluca DavideIadeluca marked this pull request as ready for review November 18, 2024 11:09
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner November 18, 2024 11:09
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.

I think for the tests, we only really need test the longest valid and assert that longer fails. Testing the local and domain parts feels like it's unnecessary and we're just testing the validator, which should already be done in Laravel?

Anyhow, I'm happy overall here, good job!

@imorland imorland merged commit 6c89f81 into flarum:1.x Nov 19, 2024
274 checks passed
@imorland imorland deleted the di/change-email-length branch November 19, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants