Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing affixed sidebar offset #4142

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

YUCLing
Copy link
Contributor

@YUCLing YUCLing commented Dec 17, 2024

Fixes #4122

Changes proposed in this pull request:
Switched to sticky positioning and fixed the missing offset by backporting #4111. Bootstrap's affix plugin is kept for compatibility.

Reviewers should focus on:

Screenshot
a27d080cab47a1f7239403c954a823fe

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@YUCLing YUCLing requested a review from a team as a code owner December 17, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.x] Side nav positioning offset missing
1 participant