Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move replies preview dropdown out of Post-footer #55

Merged
merged 1 commit into from
May 12, 2021
Merged

Move replies preview dropdown out of Post-footer #55

merged 1 commit into from
May 12, 2021

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 15, 2020

Fixes flarum/framework#1707

Sorry for the bad diff (wasn't sure how I could make it easier for review).

Instead of trying to fix the issue by hacking the CSS, moving the dropdown menu out of the Post-footer element similarly to the PostMention-preview is a cleaner solution.

Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, haven't run into issues

@SychO9 SychO9 merged commit 1066263 into flarum:master May 12, 2021
@SychO9 SychO9 deleted the sm/fix-replies-preview-dropdown branch May 12, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sizing issue with reply hover card
3 participants