This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
Use snapshots for blocklist revert #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruteri
reviewed
Nov 22, 2022
| // Apply the transaction to the current state (included in the env). | ||
| result, err := ApplyMessage(evm, msg, gp) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if preFinalizeHook != nil { | ||
| err = preFinalizeHook() |
There was a problem hiding this comment.
Should preFinalizeHook accept result?
There was a problem hiding this comment.
I agree but I decided to not add args before we actually need them.
For 1tx bundle revert we would need results, state and maybe something else too.
Ruteri
approved these changes
Nov 22, 2022
Ruteri
added a commit
that referenced
this pull request
Dec 21, 2022
avalonche
pushed a commit
that referenced
this pull request
Feb 7, 2023
avalonche
pushed a commit
that referenced
this pull request
Feb 7, 2023
* Implement block validation API * Validate proposer payment assuming its the last transaction in the block (#4) * Validate that the coinbase and feeRecipient are not blacklisted (#5) * Validate that the proposer payment has no calldata and its gas usage (#6) * Validate gas limit is set correctly wrt registered (#8) * Pass validation-specific config (#9)
avalonche
pushed a commit
that referenced
this pull request
Feb 7, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 9, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 9, 2023
* Implement block validation API * Validate proposer payment assuming its the last transaction in the block (#4) * Validate that the coinbase and feeRecipient are not blacklisted (#5) * Validate that the proposer payment has no calldata and its gas usage (#6) * Validate gas limit is set correctly wrt registered (#8) * Pass validation-specific config (#9)
avalonche
pushed a commit
that referenced
this pull request
Mar 9, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 15, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Implement block validation API * Validate proposer payment assuming its the last transaction in the block (#4) * Validate that the coinbase and feeRecipient are not blacklisted (#5) * Validate that the proposer payment has no calldata and its gas usage (#6) * Validate gas limit is set correctly wrt registered (#8) * Pass validation-specific config (#9)
avalonche
pushed a commit
that referenced
this pull request
Mar 15, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 17, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 17, 2023
* Implement block validation API * Validate proposer payment assuming its the last transaction in the block (#4) * Validate that the coinbase and feeRecipient are not blacklisted (#5) * Validate that the proposer payment has no calldata and its gas usage (#6) * Validate gas limit is set correctly wrt registered (#8) * Pass validation-specific config (#9)
avalonche
pushed a commit
that referenced
this pull request
Mar 17, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 22, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 22, 2023
* Implement block validation API * Validate proposer payment assuming its the last transaction in the block (#4) * Validate that the coinbase and feeRecipient are not blacklisted (#5) * Validate that the proposer payment has no calldata and its gas usage (#6) * Validate gas limit is set correctly wrt registered (#8) * Pass validation-specific config (#9)
avalonche
pushed a commit
that referenced
this pull request
Mar 22, 2023
avalonche
pushed a commit
that referenced
this pull request
Jul 6, 2023
avalonche
pushed a commit
that referenced
this pull request
Jul 6, 2023
* Implement block validation API * Validate proposer payment assuming its the last transaction in the block (#4) * Validate that the coinbase and feeRecipient are not blacklisted (#5) * Validate that the proposer payment has no calldata and its gas usage (#6) * Validate gas limit is set correctly wrt registered (#8) * Pass validation-specific config (#9)
avalonche
pushed a commit
that referenced
this pull request
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes state copying when applying individual tx that can potentially be reverted.